New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the first Math.round example simpler #1230

Merged
merged 3 commits into from Dec 1, 2018

Conversation

Projects
None yet
3 participants
@kevinsimper
Copy link
Contributor

kevinsimper commented Nov 8, 2018

It confusing that there are three arguments to the first console.log also since the NodeSchool.io has a chapter about rounding numbers.

@welcome

This comment has been minimized.

Copy link

welcome bot commented Nov 8, 2018

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line:

  • If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.
@wbamberg
Copy link
Member

wbamberg left a comment

I like this, but please add a semicolon to the line :).

@schalkneethling

This comment has been minimized.

Copy link
Collaborator

schalkneethling commented Nov 27, 2018

@kevinsimper Because of the following security vulnerability https://snyk.io/blog/malicious-code-found-in-npm-package-event-stream that was revealed yesterday, we are reaching out to everyone that currently has an open PR on interactive examples.

We ask that you please update your fork's master branch, and rebase your current feature branch against the new master. This will update the affected dependency to a version that is no longer affected, and remove the security concern.

We appreciate your assistance in this matter. Should you need any assistance, please feel free to reach out.

wbamberg added some commits Dec 1, 2018

Merge remote-tracking branch 'upstream/master' into patch-1
* upstream/master:
  Put prefixed sticky value before standard value (#1249)
  Added grid-area label indicators to div content (#1248)
  Update dependency mdn-bob to v1.1.20 (#1241)
  Update dependency prettier to v1.15.2 (#1234)
  Update dependency eslint to v5.9.0 (#1233)
  Update dependency stylelint to v9.8.0 (#1232)
  Update dependency npm-run-all to v4.1.5 (#1239)
  Provide valid and more semantic HTML with <audio> (#1236)
  remove Jenkinsfile code related to MozMEAO
  fix issues with the Jenkins build step

@wbamberg wbamberg merged commit 24100f6 into mdn:master Dec 1, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (schalkneethling) No new issues
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Dec 1, 2018

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment