/interactive-examples

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Math.trunc] - Negative numbers #1264

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Reviewers

@wbamberg wbamberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Marabyte @wbamberg
@Marabyte
Copy link
Contributor

Marabyte commented Dec 10, 2018

The expected output of Math.trunc for negative numbers should be a negative number
@Marabyte
[Math.trunc] - Negative numbers 
The expected output of Math.trunc for negative numbers should be a negative number
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a3770c3
@welcome

This comment has been minimized.

Sign in to view
Copy link

welcome bot commented Dec 10, 2018

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line:

  • If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.
@wbamberg

wbamberg approved these changes Dec 10, 2018
View changes

Copy link
Member

wbamberg left a comment •
edited

Thanks @Marabyte ! Looks like a good change.

@wbamberg wbamberg merged commit 7165850 into mdn:master Dec 10, 2018
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (schalkneethling) No new issues
Details
@welcome

This comment has been minimized.

Sign in to view
Copy link

welcome bot commented Dec 10, 2018

Congrats on merging your first pull request! 🎉🎉🎉

rachelandrew added a commit to rachelandrew/interactive-examples that referenced this pull request Dec 16, 2018

@Marabyte @rachelandrew
[Math.trunc] - Negative numbers (mdn#1264) 
The expected output of Math.trunc for negative numbers should be a negative number
2f3e876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment