Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
added conic gradient examples #1265
kevinsimper left a comment •
Nice with examples for
wbamberg left a comment
This works and looks great. I had a couple of comments on the content, though, and there's another issue about how the editor handles browser support.
The problem then of course is vertical scrollbars, which we also want to avoid :). But in this case actually it looks like we have enough vertical space that we can make options 2 and 3 multiline, and thereby avoid all scrollbars.
The other problem here is that the example doesn't seem to work on Firefox - I don't see any output. Is this function not supported in Firefox? The interactive editor doesn't work very well for unsupported items, and we have an issue for this (#532) but it's not a high priority because it doesn't affect very many pages, because cross-browser support is in general pretty good. For now we just don't include examples for items that don't have good cross-browser support.
(There is another issue in here, where the technique we use to tell the editor whether an item is unsupported won't work in this particular case, because it only works on a per-property basis, not for particular values of properties. But given that the UX for unsupported items is so bad even when we can reliably detect it, I don't think that is worth worrying about today.)