Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 561 Added example for vertical-align in text context #606

Merged
merged 6 commits into from Feb 23, 2018

Conversation

@LLyaudet
Copy link
Contributor

@LLyaudet LLyaudet commented Feb 22, 2018

Hello @wbamberg,
Here is the pull request for vertical-align. I put my commit in a branch issue-561-css-vertical-align if there is any correction to add to the branch.
Best regards,
Laurent Lyaudet

@welcome
Copy link

@welcome welcome bot commented Feb 22, 2018

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line: - If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.

Loading

…tical-align

* upstream/master:
  Logical properties (mdn#598)
  Revert "Adds next iteration of the HTML interactive editor (mdn#576)" (mdn#605)
Copy link
Collaborator

@wbamberg wbamberg left a comment

I think this works great :).

I pushed a merge from the latest master, because the master you started from had a problem which stopped the example from working.

Apart from that, the only thing I can see is that this example doesn't belong in the "text" directory. We are trying to organize CSS examples by the specification that defines them, and I think "inline-layout" would be the right directory for this property, mapping to https://drafts.csswg.org/css-inline/.

Loading

@LLyaudet
Copy link
Contributor Author

@LLyaudet LLyaudet commented Feb 23, 2018

Hello @wbamberg,
I pushed the commit for moving the source in a new directory inline-layout under css-examples.
I modified meta.json in text directory and created one such file in inline-layout directory.
Is there anything else to do to have the inline-layout examples up and running ?
There is also merge commits since I messed up by fetching upstream and merging from upstream master into my branch instead of pulling my branch with the merge you did from my fork.
I need practice on this. That's my first pull request.
Best regards,
Laurent Lyaudet

Loading

@wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented Feb 23, 2018

This looks fine! Just you forgot to update the paths inside meta.json when you moved the files from "text" to "inline-layout". I just pushed a commit taking care of that. I also made the CSS selector more specific - as you pointed out before, it is possible for styles in here to interfere with the whole example - they don't in this particular case, but still it seems like a good idea to avoid that possibility.

Loading

Copy link
Collaborator

@wbamberg wbamberg left a comment

Thanks for your contribution @LLyaudet !

Loading

@wbamberg wbamberg merged commit 70df944 into mdn:master Feb 23, 2018
1 check passed
Loading
@welcome
Copy link

@welcome welcome bot commented Feb 23, 2018

Congrats on merging your first pull request! 🎉🎉🎉

Loading

@wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented Feb 24, 2018

Loading

@LLyaudet LLyaudet deleted the issue-561-css-vertical-align branch Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants