New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <kbd> example #756

Merged
merged 1 commit into from Apr 23, 2018

Conversation

Projects
2 participants
@Elchi3
Member

Elchi3 commented Apr 20, 2018

Hello, this is my first contribution to this repo.
Example for https://developer.mozilla.org/en-US/docs/Web/HTML/Element/kbd

@welcome

This comment has been minimized.

welcome bot commented Apr 20, 2018

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line: - If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.

@Elchi3

This comment has been minimized.

Member

Elchi3 commented Apr 23, 2018

Rebased.

@schalkneethling schalkneethling added this to To do in Q2 - Sprint 2 via automation Apr 23, 2018

@schalkneethling schalkneethling added this to the Quarter 2 ~ Sprint 2 milestone Apr 23, 2018

@schalkneethling

Couple of code style issues. Other than those r+w/c ~ Thanks @Elchi3

@@ -0,0 +1,6 @@
kbd {
background: #f5f5f5;

This comment has been minimized.

@schalkneethling

schalkneethling Apr 23, 2018

Collaborator

Nit: Code style: indentation of 4 spaces. Also, as this specifies only a colour, use background-color instead of the shorthand.

background: #f5f5f5;
border-style: solid;
border-width: 1px 2px 2px 1px;
padding: 0px 1px 0px 1px;

This comment has been minimized.

@schalkneethling

schalkneethling Apr 23, 2018

Collaborator

Nit: Code style: no units with 0 values. Can also be shortened - padding: 0 1px;

"exampleCode": "live-examples/html-examples/inline-text-semantics/kbd.html",
"cssExampleSrc": "live-examples/html-examples/inline-text-semantics/css/kbd.css",
"fileName": "kbd.html",
"title": "HTML Demo: &lt;kbd&gt;",

This comment has been minimized.

@Elchi3

Elchi3 Apr 23, 2018

Member

This should be <kbd> if #777 gets merged before.

This comment has been minimized.

@schalkneethling

schalkneethling Apr 23, 2018

Collaborator

Yeah, I reckon this one will merge first.

@schalkneethling

r+ Thanks @Elchi3

@schalkneethling schalkneethling merged commit 609ef54 into mdn:master Apr 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Q2 - Sprint 2 automation moved this from To do to Done Apr 23, 2018

@welcome

This comment has been minimized.

welcome bot commented Apr 23, 2018

Congrats on merging your first pull request! 🎉🎉🎉

wbamberg added a commit to schalkneethling/interactive-examples that referenced this pull request Apr 23, 2018

Merge remote-tracking branch 'upstream/master' into issue774-encode-e…
…xample-titles

* upstream/master:
  Add <kbd> example (mdn#756)

@Elchi3 Elchi3 deleted the Elchi3:html-kbd branch Apr 23, 2018

@Elchi3

This comment has been minimized.

Member

Elchi3 commented Apr 24, 2018

I've added this to the page https://developer.mozilla.org/en-US/docs/Web/HTML/Element/kbd
There is a scrollbar for me, though. Not sure if I did this correctly.

@schalkneethling

This comment has been minimized.

Collaborator

schalkneethling commented Apr 24, 2018

@Elchi3 yeah, we are not yet rolling this out until we have resolved the current blocker - #706

We also probably need to add a custom class to avoid the scrolling. This would need to be added on the Kuma side and then it would need a production push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment