New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <mark> example #775

Merged
merged 1 commit into from Apr 24, 2018

Conversation

Projects
2 participants
@Elchi3
Member

Elchi3 commented Apr 23, 2018

@schalkneethling

One small nit. Other than that, r+w/c Thanks @Elchi3

<ul>
<li><a href="https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API/Tutorial">Canvas <mark>tutorials</mark></a>. How to use the canvas element to draw 2D graphics, starting with the basics.</li>

This comment has been minimized.

@schalkneethling

schalkneethling Apr 23, 2018

Collaborator

Nit: No empty line between list items.

@schalkneethling schalkneethling added this to To do in Q2 - Sprint 2 via automation Apr 23, 2018

@schalkneethling schalkneethling added this to the Quarter 2 ~ Sprint 2 milestone Apr 23, 2018

@Elchi3

This comment has been minimized.

Member

Elchi3 commented Apr 24, 2018

Updated. Also changed the title to no longer use the encoded stuff.

@Elchi3

This comment has been minimized.

Member

Elchi3 commented Apr 24, 2018

Wait, if I'm not using any CSS, I shouldn't use the tabbed template but the html template, right?

Otheriwse (and this is the current state), if I'm not using "cssExampleSrc" in meta.json, there will be a CSS tab and the content is a placeholder string "%example-css-src%".

@schalkneethling

This comment has been minimized.

Collaborator

schalkneethling commented Apr 24, 2018

@Elchi3 Yup, you are kinda correct. So, we pretty much assumed that all HTML examples will have at least some CSS so, for now the code also makes that assumption.

The ultimate idea is for this to be "configurable". If there is CSS it adds the tab, else I does not.

While not needed at all, I would suggest that for this example, perhaps make the paragraph potion larger so there is some CSS ;)

p {
    font-size: 1.2rem;
}

Thanks!

@Elchi3

This comment has been minimized.

Member

Elchi3 commented Apr 24, 2018

Ok!
Given this is about <mark>, I think it would be good to just have an empty rule so that people can get right into playing with the CSS for <mark> if they want to.

@schalkneethling schalkneethling merged commit 8be1f0d into mdn:master Apr 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Q2 - Sprint 2 automation moved this from To do to Done Apr 24, 2018

@Elchi3 Elchi3 deleted the Elchi3:html-mark branch Apr 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment