Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interactive example for dl element #826

Merged
merged 3 commits into from Apr 26, 2018

Conversation

Projects
2 participants
@a2sheppy
Copy link
Collaborator

a2sheppy commented Apr 25, 2018

Simple interactive example for <dl>. Probably will use modifications of this same code for <dt> and <dd> -- but not the exact same example, because that can mess up SEO.

@schalkneethling
Copy link
Collaborator

schalkneethling left a comment

Very nice example, thanks @a2sheppy ~ Acouple of code style nits. Other than that r+w/c

@font-face {
font-family: "Fira Sans";
src: local("FiraSans-Regular"),
url("/media/fonts/FiraSans-Regular.woff2") format("woff2");

This comment has been minimized.

@schalkneethling

schalkneethling Apr 26, 2018

Collaborator

Nit: Code style: Use single quotes. Here and above

This comment has been minimized.

@a2sheppy

a2sheppy Apr 26, 2018

Author Collaborator

Eep. That'll take reprogramming muscle memory, as in 12 years of documenting at Mozilla I've always used double quotes. I'll change this. :)

url("/media/fonts/FiraSans-Regular.woff2") format("woff2");
}

p, dl {

This comment has been minimized.

@schalkneethling

schalkneethling Apr 26, 2018

Collaborator

Nit: Code style: Each selector on its own row

This comment has been minimized.

@a2sheppy

a2sheppy Apr 26, 2018

Author Collaborator

This line was copied from another example (<ol>), so that one should be updated too.

This comment has been minimized.

@a2sheppy

a2sheppy Apr 26, 2018

Author Collaborator

Ignore this push. Something very weird went wrong, and the wrong stuff went up.

}

p, dl {
font: 1rem "Fira Sans", sans-serif;

This comment has been minimized.

@schalkneethling

schalkneethling Apr 26, 2018

Collaborator

Nit: Code style: Use single quotes

dl > dt {
font-weight: bold;
text-decoration: underline;
}

This comment has been minimized.

@schalkneethling

schalkneethling Apr 26, 2018

Collaborator

Nit: Missing empty line at end of file

This comment has been minimized.

@a2sheppy

a2sheppy Apr 26, 2018

Author Collaborator

Weird, my editor is configured to alert me if I do that. Fixing it.

@schalkneethling schalkneethling self-assigned this Apr 26, 2018

@schalkneethling
Copy link
Collaborator

schalkneethling left a comment

w00t ~ Thanks @a2sheppy r+

@schalkneethling schalkneethling merged commit d5f2394 into mdn:master Apr 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Apr 26, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@schalkneethling schalkneethling added this to To do in Q2 - Sprint 2 via automation Apr 26, 2018

@schalkneethling schalkneethling added this to the Quarter 2 ~ Sprint 2 milestone Apr 26, 2018

@a2sheppy a2sheppy deleted the a2sheppy:html-dl-element branch Apr 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.