New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue #767] [HTML Examples] Inline text semantics ~ br #828

Merged
merged 4 commits into from May 8, 2018

Conversation

Projects
2 participants
@atopal
Member

atopal commented Apr 26, 2018

@atopal atopal added this to the Quarter 2 ~ Sprint 2 milestone Apr 26, 2018

@atopal atopal added this to To do in Q2 - Sprint 2 via automation Apr 26, 2018

@welcome

This comment has been minimized.

welcome bot commented Apr 26, 2018

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line: - If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.

@wbamberg

Very nice example! One formatting issue, and a totally optional question.

"fileName": "br.html",
"title": "HTML Demo: <br>",
"type": "tabbed"
},

This comment has been minimized.

@wbamberg

wbamberg Apr 26, 2018

Member

Indentation is off for these.

@@ -0,0 +1,5 @@
p {
font-size: 1rem;
font-family: sans-serif;

This comment has been minimized.

@wbamberg

wbamberg Apr 26, 2018

Member

Total nit, but is there a reason to not combine these, like:

font: 1rem/24px sans-serif;

@schalkneethling schalkneethling requested a review from wbamberg May 1, 2018

@wbamberg wbamberg assigned atopal and unassigned wbamberg May 4, 2018

@wbamberg

Fixing the merge conflict also fixed the formatting issue, so r+

@wbamberg wbamberg merged commit 401611c into mdn:master May 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json No dependency changes
Details

Q2 - Sprint 2 automation moved this from To do to Done May 8, 2018

@welcome

This comment has been minimized.

welcome bot commented May 8, 2018

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment