Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add picture example. #842
Thanks for your contribution! this is a nice example! I did have some comments:
I hope that helps!
This looks great! Thanks for the updates.
I had a few formatting suggestions:
The simplest fix for this is just to remove the
(I also think you can omit the period "." in the footer.)
But I would also like to know if @schalkneethling has opinions on attribution for Unsplash images. In other cases we haven't included any links (
With that said, I am thinking we should have a standard piece of HTML you can use to add these to an example which is consistent. And with regards to linking, linking to both Unsplash and the creator is not required. Just linking to the creator is sufficient.
Any thoughts @wbamberg
@schalkneethling , here's what I suggest:
For this PR, let's add a footer like:
That means @sheeeng is able to finish this PR without having to wait for us to decide on a general policy.
Separately I'll file an issue to decide what to do about attribution in general, and we'll use the resolution of that to update all relevant examples.