New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <del> example #844

Merged
merged 2 commits into from Apr 29, 2018

Conversation

Projects
None yet
2 participants
@2alin
Contributor

2alin commented Apr 29, 2018

Fixes #735

@wbamberg

This comment has been minimized.

Member

wbamberg commented Apr 29, 2018

This is a very nice example! You don't need line-height: 1.5;, because that's already set on.output
And I would make the text a little bigger with something like font-size: 1rem;, what do you think?

@2alin

This comment has been minimized.

Contributor

2alin commented Apr 29, 2018

It works for me. I prefer small text 😅 but I do agree that 1rem will suit better here because of the short example.
And it's updated 😉

@wbamberg

Looks great to me @2alin , thanks for your contribution!

@wbamberg wbamberg merged commit 2f13431 into mdn:master Apr 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@2alin 2alin deleted the 2alin:del-element-example branch Apr 29, 2018

wbamberg added a commit to wbamberg/interactive-examples that referenced this pull request May 1, 2018

Merge remote-tracking branch 'upstream/master'
* upstream/master:
  adding examples for td,th, and tr (mdn#849)
  Update footer example css (mdn#845)
  Configure Renovate (mdn#850)
  Add <del> example (mdn#844)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment