New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#860 change output to shadow dom tabbed editor #873

Merged
merged 1 commit into from May 3, 2018

Conversation

Projects
2 participants
@schalkneethling
Collaborator

schalkneethling commented May 2, 2018

This is phase 1 of the change so, the output will not work in Firefox or Edge. The next pull request will add the required polyfills

@wbamberg

This comment has been minimized.

Member

wbamberg commented May 2, 2018

This works great! What a nice solution. I'll leave it to you to merge in case you want to fix the failing test first.

@schalkneethling schalkneethling merged commit 5d47f7b into mdn:master May 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Q2 - Sprint 2 automation moved this from To do to Done May 3, 2018

sheeeng added a commit to sheeeng/interactive-examples that referenced this pull request May 3, 2018

wbamberg added a commit to wbamberg/interactive-examples that referenced this pull request May 4, 2018

Merge remote-tracking branch 'origin/add-html-input-number' into add-…
…html-input-number

* origin/add-html-input-number:
  Add input-image example (mdn#864)
  Add html input radio (mdn#868)
  Add iframe example. (mdn#875)
  fix: change output for tabbed editor to shadow dom (mdn#873)
  fix: run tests on different port than dev server (mdn#871)
  Add <var> example (mdn#872)
  Add <dd> example (mdn#839)
  Remove unused CSS
  Add <ins> example (mdn#847)
  chore: add @sheeeng as contributor (mdn#869)
  test: add sanity pupeteer tests for tabbed editor (mdn#717)
  Adds sanity puppeteer test for CSS editor (mdn#716)
  Add input-month example

wbamberg added a commit to wbamberg/interactive-examples that referenced this pull request May 5, 2018

Merge remote-tracking branch 'upstream/master'
* upstream/master:
  Add interactive example for <section> (mdn#888)
  Add embed example. (mdn#863)
  Add <span> example (mdn#882)
  chore: add @tbazin as contributor (mdn#889)
  Improve naming of unbound function example (mdn#886)
  Add html input number (mdn#866)
  Add html input range (mdn#878)
  chore(deps): update dependency jest-puppeteer to v3 (mdn#879)
  Add input-image example (mdn#864)
  Add html input radio (mdn#868)
  Add iframe example. (mdn#875)
  fix: change output for tabbed editor to shadow dom (mdn#873)
  Remove unused CSS
  Add input-month example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment