New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve js/function_bind example #886

Merged
merged 1 commit into from May 4, 2018

Conversation

Projects
None yet
2 participants
@tbazin
Contributor

tbazin commented May 3, 2018

No description provided.

@welcome

This comment has been minimized.

welcome bot commented May 3, 2018

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line: - If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.

@wbamberg

This looks like a good change to me. Thanks for your contribution @tbazin !

@wbamberg wbamberg merged commit abfcb87 into mdn:master May 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

welcome bot commented May 4, 2018

Congrats on merging your first pull request! 🎉🎉🎉

wbamberg added a commit to wbamberg/interactive-examples that referenced this pull request May 5, 2018

Merge remote-tracking branch 'upstream/master'
* upstream/master:
  Add interactive example for <section> (mdn#888)
  Add embed example. (mdn#863)
  Add <span> example (mdn#882)
  chore: add @tbazin as contributor (mdn#889)
  Improve naming of unbound function example (mdn#886)
  Add html input number (mdn#866)
  Add html input range (mdn#878)
  chore(deps): update dependency jest-puppeteer to v3 (mdn#879)
  Add input-image example (mdn#864)
  Add html input radio (mdn#868)
  Add iframe example. (mdn#875)
  fix: change output for tabbed editor to shadow dom (mdn#873)
  Remove unused CSS
  Add input-month example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment