New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update <blockquote> example #906

Merged
merged 4 commits into from May 9, 2018

Conversation

Projects
3 participants
@wbamberg

This is a much better example, thanks Florian! One comment.

blockquote p::before,
blockquote p::after {
content: '\201C';

This comment has been minimized.

@wbamberg

wbamberg May 8, 2018

Member

This character is directional, so I think you'll want:

blockquote p::before {
	content: '\201C';
}

blockquote p::after {
  content: '\201D';
}

This comment has been minimized.

@wbamberg

wbamberg May 9, 2018

Member

...only with less random indentation, I guess :-)

@Elchi3

This comment has been minimized.

Member

Elchi3 commented May 9, 2018

Thanks Will! Updated.

@schalkneethling schalkneethling added this to To do in Q2 - Sprint 2 via automation May 9, 2018

@schalkneethling schalkneethling added this to To do in Examples Needed via automation May 9, 2018

@schalkneethling schalkneethling added this to the Quarter 2 ~ Sprint 2 milestone May 9, 2018

@wbamberg

Thanks! I also pushed a change to add blank lines between CSS rules.

@wbamberg

This comment has been minimized.

Member

wbamberg commented May 9, 2018

This test failure was already there and will be fixed by #912.

@wbamberg wbamberg merged commit c9f0f8d into mdn:master May 9, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
security/snyk - package.json No dependency changes
Details

Q2 - Sprint 2 automation moved this from To do to Done May 9, 2018

Examples Needed automation moved this from To do to Done May 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment