New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Array.prototype.values() #917

Merged
merged 3 commits into from May 10, 2018

Conversation

Projects
None yet
2 participants
@sidvishnoi
Contributor

sidvishnoi commented May 10, 2018

First time here. Starting with a simple one :)
Hope to contribute more :)

@welcome

This comment has been minimized.

welcome bot commented May 10, 2018

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line: - If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.

sidvishnoi added some commits May 10, 2018

@wbamberg

Looks good to me. Thanks for your contribution @sidvishnoi !

@wbamberg wbamberg merged commit 9e20201 into mdn:master May 10, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json No dependency changes
Details
@welcome

This comment has been minimized.

welcome bot commented May 10, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@sidvishnoi sidvishnoi deleted the sidvishnoi:array-values branch May 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment