Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML example for <summary> #926

Merged
merged 3 commits into from May 18, 2018

Conversation

Projects
3 participants
@Regaddi
Copy link
Contributor

Regaddi commented May 16, 2018

The merge will potentially fail, when #924 is merged before, because I created a new directory for the interactive elements.
I created a slightly simpler example compared to my <details> example.
I can surely do a rebase and fix the merge conflicts if #924 is merged before.

Christian Stuff

@schalkneethling schalkneethling self-requested a review May 17, 2018

@schalkneethling schalkneethling self-assigned this May 17, 2018

@schalkneethling schalkneethling added this to To do in Q2 Sprint 3 via automation May 17, 2018

@schalkneethling schalkneethling added this to To do in Examples Needed via automation May 17, 2018

@wbamberg
Copy link
Member

wbamberg left a comment

Thanks again @Regaddi !

I had the same comment as for the details example, about using content for the demo that's not documentation for the thing being demoed.

Also I did like the styling for the details example, and I think this is a bit under-styled. In particular when the details are displayed it's hard to see the difference between the summary text and the details text. There are (obviously) lots of ways to do that,but I thought just using the same styles you had for details would work fine.

@Regaddi

This comment has been minimized.

Copy link
Contributor Author

Regaddi commented May 17, 2018

@wbamberg I copied the styles over from #924 and changed the content.

@wbamberg
Copy link
Member

wbamberg left a comment

Ha, nice example :).

Thanks again @Regaddi !

@wbamberg wbamberg merged commit e50c37f into mdn:master May 18, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json No dependency changes
Details

Examples Needed automation moved this from To do to Done May 18, 2018

Q2 Sprint 3 automation moved this from To do to Done May 18, 2018

wbamberg added a commit to wbamberg/interactive-examples that referenced this pull request May 25, 2018

Merge remote-tracking branch 'upstream/master'
* upstream/master: (39 commits)
  Add video example. (mdn#939)
  Add track example. (mdn#940)
  Change `html` to `tabbed` in Publishing section (mdn#942)
  adding font-optical-sizing example (mdn#919)
  chore(deps): update dependency jest to v22.4.4 (mdn#935)
  fix(tabbed-editor): issue mdn#860, isolate CSS to output (mdn#927)
  Add img example. (mdn#923)
  Add <area> example (mdn#920)
  Add <map> example (mdn#931)
  Add HTML example for <audio> (mdn#930)
  chore(community): add @Regaddi as contributor (mdn#933)
  chore(community): add @stephanmax as contributor (mdn#932)
  Add HTML example for <summary> (mdn#926)
  Add HTML example for <details> (mdn#924)
  Fix example: issue mdn#925, add (max-)width to container and left-align text to see full effect (mdn#929)
  Add String trim examples (mdn#922)
  chore(deps): update dependency stylelint to v9.2.1 (mdn#928)
  Add example for week input (mdn#902)
  Add url input example (mdn#901)
  Add html input search (mdn#897)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.