New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabbed-editor): issue #860, isolate CSS to output #927

Merged
merged 2 commits into from May 19, 2018

Conversation

@schalkneethling
Collaborator

schalkneethling commented May 16, 2018

This has been tested in Chrome(and other Webkit/Blink browsers) as well as Firefox. Still need to confirm that this works in Edge as well. The VM is pretty large so, while it download, this is good for review.

@wbamberg

This seems to work fine. I'm glad you found a way to get the polyfill to work :).

If I were you, I'd also want a review from a front-end developer.

@schalkneethling

This comment has been minimized.

Collaborator

schalkneethling commented May 19, 2018

@wbamberg Thanks for the review. I do agree with you but, at this stage I am not sure who to ping for it, and I fear that this hangs around turning stale while I wait on someone.

When I was asking around for help, I could not find anyone that had experience with ShadowDOM, and more specifically with the polyfills.

The code I am using now for ShadowDOM means that browsers that does not support ES6 will not work so, I need to add Babel to compile the code down to a support matrix we target. I have wanted to do this for some time here and on MDN so, no time like the present ;)

I will ask for review, but I am also going to go ahead and merge this so I can work on the next piece. I can always open up pull requests later should someone point out ways that this can be improved upon.

@schalkneethling schalkneethling added this to the Q2 ~ Sprint 3 milestone May 19, 2018

@schalkneethling schalkneethling merged commit ce496cd into mdn:master May 19, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json No dependency changes
Details

interactive editor v2 automation moved this from Backlog to Done May 19, 2018

wbamberg added a commit to wbamberg/interactive-examples that referenced this pull request May 25, 2018

Merge remote-tracking branch 'upstream/master'
* upstream/master: (39 commits)
  Add video example. (mdn#939)
  Add track example. (mdn#940)
  Change `html` to `tabbed` in Publishing section (mdn#942)
  adding font-optical-sizing example (mdn#919)
  chore(deps): update dependency jest to v22.4.4 (mdn#935)
  fix(tabbed-editor): issue mdn#860, isolate CSS to output (mdn#927)
  Add img example. (mdn#923)
  Add <area> example (mdn#920)
  Add <map> example (mdn#931)
  Add HTML example for <audio> (mdn#930)
  chore(community): add @Regaddi as contributor (mdn#933)
  chore(community): add @stephanmax as contributor (mdn#932)
  Add HTML example for <summary> (mdn#926)
  Add HTML example for <details> (mdn#924)
  Fix example: issue mdn#925, add (max-)width to container and left-align text to see full effect (mdn#929)
  Add String trim examples (mdn#922)
  chore(deps): update dependency stylelint to v9.2.1 (mdn#928)
  Add example for week input (mdn#902)
  Add url input example (mdn#901)
  Add html input search (mdn#897)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment