New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example: issue #925, add (max-)width to container #929

Merged
merged 1 commit into from May 17, 2018

Conversation

Projects
3 participants
@stephanmax
Contributor

stephanmax commented May 16, 2018

I used the max-width/width combination to make that example also work on narrow screens. Left-aligning the paragraph also keeps the text from slightly "jumping" between clip and ellipsis and is hopefully less distracting from the intended effect.

@welcome

This comment has been minimized.

welcome bot commented May 16, 2018

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line: - If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.

@schalkneethling schalkneethling self-requested a review May 17, 2018

@schalkneethling schalkneethling self-assigned this May 17, 2018

@schalkneethling schalkneethling added this to To Do in All the Boogz via automation May 17, 2018

@schalkneethling schalkneethling added this to To do in Q2 Sprint 3 via automation May 17, 2018

@wbamberg

Thanks! This looks great.

@@ -9,4 +10,5 @@
white-space: nowrap;
font-family: sans-serif;
padding: 0 0.5em;
text-align: left;

This comment has been minimized.

@wbamberg

wbamberg May 17, 2018

Member

Yes, that's a nice change too.

@wbamberg wbamberg merged commit d0787d4 into mdn:master May 17, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json No dependency changes
Details

All the Boogz automation moved this from To Do to Done May 17, 2018

Q2 Sprint 3 automation moved this from To do to Done May 17, 2018

@welcome

This comment has been minimized.

welcome bot commented May 17, 2018

Congrats on merging your first pull request! 🎉🎉🎉

wbamberg added a commit to wbamberg/interactive-examples that referenced this pull request May 25, 2018

Merge remote-tracking branch 'upstream/master'
* upstream/master: (39 commits)
  Add video example. (mdn#939)
  Add track example. (mdn#940)
  Change `html` to `tabbed` in Publishing section (mdn#942)
  adding font-optical-sizing example (mdn#919)
  chore(deps): update dependency jest to v22.4.4 (mdn#935)
  fix(tabbed-editor): issue mdn#860, isolate CSS to output (mdn#927)
  Add img example. (mdn#923)
  Add <area> example (mdn#920)
  Add <map> example (mdn#931)
  Add HTML example for <audio> (mdn#930)
  chore(community): add @Regaddi as contributor (mdn#933)
  chore(community): add @stephanmax as contributor (mdn#932)
  Add HTML example for <summary> (mdn#926)
  Add HTML example for <details> (mdn#924)
  Fix example: issue mdn#925, add (max-)width to container and left-align text to see full effect (mdn#929)
  Add String trim examples (mdn#922)
  chore(deps): update dependency stylelint to v9.2.1 (mdn#928)
  Add example for week input (mdn#902)
  Add url input example (mdn#901)
  Add html input search (mdn#897)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment