New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <map> example #931

Merged
merged 2 commits into from May 18, 2018

Conversation

Projects
2 participants
@2alin
Contributor

2alin commented May 18, 2018

Fixes #761

Another one full of fun 馃榿.
I followed the guidelines discussed in #920. Hope I didn't make a mistake and everything is alright.

Because it's a demo for <map> and not <area> I decided to not saturate it with all different kinds of shapes and went only with poly (the <area> demo has all types implemented).

And again, the graphic was completely made by me from scratch in Inkscape, even the idea is original. So, no problems of copyright 馃槈.

@2alin 2alin changed the title from add <map> example to Add <map> example May 18, 2018

@schalkneethling schalkneethling self-requested a review May 18, 2018

@schalkneethling schalkneethling self-assigned this May 18, 2018

@schalkneethling schalkneethling added this to To do in Examples Needed via automation May 18, 2018

@schalkneethling schalkneethling added this to To do in Q2 Sprint 3 via automation May 18, 2018

@schalkneethling schalkneethling added this to the Q2 ~ Sprint 3 milestone May 18, 2018

@schalkneethling

Wow, what a beautiful example. Thanks @2alin - One super tiny nit, and then this is good to merge. r+w/c

href="https://developer.mozilla.org/docs/Web/JavaScript"
target="_blank" alt="JavaScript" />
</map>
<img usemap="#infographic" src="/media/examples/mdn-info2.png" alt="MDN infographic">

This comment has been minimized.

@schalkneethling

schalkneethling May 18, 2018

Collaborator

Nit: Code style: Explicitly close self closing elements.

This comment has been minimized.

@2alin

2alin May 18, 2018

Contributor

in <img>?

This comment has been minimized.

@schalkneethling

schalkneethling May 18, 2018

Collaborator

Yup, so:

<img usemap="#infographic" src="/media/examples/mdn-info2.png" alt="MDN infographic" />

@schalkneethling schalkneethling merged commit 74b45ea into mdn:master May 18, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
security/snyk - package.json No new issues
Details

Examples Needed automation moved this from To do to Done May 18, 2018

Q2 Sprint 3 automation moved this from To do to Done May 18, 2018

@2alin

This comment has been minimized.

Contributor

2alin commented May 18, 2018

Thank you for reviewing it and the fast merge :)

@2alin 2alin deleted the 2alin:add-map-example branch May 18, 2018

wbamberg added a commit to wbamberg/interactive-examples that referenced this pull request May 25, 2018

Merge remote-tracking branch 'upstream/master'
* upstream/master: (39 commits)
  Add video example. (mdn#939)
  Add track example. (mdn#940)
  Change `html` to `tabbed` in Publishing section (mdn#942)
  adding font-optical-sizing example (mdn#919)
  chore(deps): update dependency jest to v22.4.4 (mdn#935)
  fix(tabbed-editor): issue mdn#860, isolate CSS to output (mdn#927)
  Add img example. (mdn#923)
  Add <area> example (mdn#920)
  Add <map> example (mdn#931)
  Add HTML example for <audio> (mdn#930)
  chore(community): add @Regaddi as contributor (mdn#933)
  chore(community): add @stephanmax as contributor (mdn#932)
  Add HTML example for <summary> (mdn#926)
  Add HTML example for <details> (mdn#924)
  Fix example: issue mdn#925, add (max-)width to container and left-align text to see full effect (mdn#929)
  Add String trim examples (mdn#922)
  chore(deps): update dependency stylelint to v9.2.1 (mdn#928)
  Add example for week input (mdn#902)
  Add url input example (mdn#901)
  Add html input search (mdn#897)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment