Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Implemented example for <figcaption> tag #941
changed the title from
Implemented example for <figcapture> tag
Implemented example for <figcaption> tag
May 19, 2018
referenced this pull request
May 22, 2018
Thanks for your contribution, and sorry to be so slow reviewing this. In general this looks great!
I just have a couple of very nitpicky comments.
One other comment is that we're always attributing the images we use. In this case we'd use something like:
Photo by Ricky Kharawala on Unsplash
Perhaps we could include it in the
figcaption itself, by making it something like:
Hamster by Ricky Kharawala on Unsplash
...if you do that, it would probably be worth setting
margin: 1rem; or something like that on the
figure, so the caption gets a bit more horizontal space and won't wrap so readily.