This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
bug 1404669: optional cleanup #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the "template_url_template" setting has been obsolete for some time, so remove it * update the "document_url_template" setting defaults to reflect the addition of "redirect=no" to its parameters
1 task
davidflanagan
approved these changes
Jan 4, 2019
|
@davidflanagan Thanks for the review! Other than as a kind of documentation of what the real value is expected to look like, there really is no benefit to adding |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs some minor cleanup related to the work that was done for bug 1404669. None of this cleanup is required to actually fix the bug.
document_url_templateto reflect the addition ofredirect=notemplate_url_templatesetting has been obsolete for some time, so it has been removed