New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 1372610: fix master Jenkins pipeline #206

Merged
merged 1 commit into from Jun 13, 2017

Conversation

Projects
None yet
2 participants
@escattone
Member

escattone commented Jun 13, 2017

Fix the Jenkins pipeline for the master branch.

@escattone escattone requested a review from jwhitlock Jun 13, 2017

@jwhitlock

This comment has been minimized.

Show comment
Hide comment
@jwhitlock

jwhitlock Jun 13, 2017

Member

That might work. However, the latest in quay.io is also really out of date. Were you going to manually upload a new image?

It would also help to push the branch to the mozilla repo, so we don't have to guess if it will work 😄

Member

jwhitlock commented Jun 13, 2017

That might work. However, the latest in quay.io is also really out of date. Were you going to manually upload a new image?

It would also help to push the branch to the mozilla repo, so we don't have to guess if it will work 😄

@escattone

This comment has been minimized.

Show comment
Hide comment
@escattone

escattone Jun 13, 2017

Member

My understanding is that the make lint-macros VERSION=latest from the "Test" stage will use the local/cached Docker image built and tagged with quay.io/mozmar/kumascript\:latest from the "Build" stage (and not from quay.io), but maybe I'm off?

Since this bug only appears on the master branch, I didn't want to push to the mozilla repo, but I suppose I could put a separate mozilla branch in the Jenkinsfile (without the push step), push to it, and test it that way.

Member

escattone commented Jun 13, 2017

My understanding is that the make lint-macros VERSION=latest from the "Test" stage will use the local/cached Docker image built and tagged with quay.io/mozmar/kumascript\:latest from the "Build" stage (and not from quay.io), but maybe I'm off?

Since this bug only appears on the master branch, I didn't want to push to the mozilla repo, but I suppose I could put a separate mozilla branch in the Jenkinsfile (without the push step), push to it, and test it that way.

@escattone

This comment has been minimized.

Show comment
Hide comment
@escattone

escattone Jun 13, 2017

Member

I added a "fix-jenkins-master-pipeline-1372610" branch to the Jenkinsfile, pushed it to the mozilla repo for testing purposes (https://github.com/mozilla/kumascript/tree/fix-jenkins-master-pipeline-1372610), and it passed (see https://ci.us-west.moz.works/blue/organizations/jenkins/kumascript_multibranch_pipeline/detail/fix-jenkins-master-pipeline-1372610/1/pipeline).

Member

escattone commented Jun 13, 2017

I added a "fix-jenkins-master-pipeline-1372610" branch to the Jenkinsfile, pushed it to the mozilla repo for testing purposes (https://github.com/mozilla/kumascript/tree/fix-jenkins-master-pipeline-1372610), and it passed (see https://ci.us-west.moz.works/blue/organizations/jenkins/kumascript_multibranch_pipeline/detail/fix-jenkins-master-pipeline-1372610/1/pipeline).

@jwhitlock

Thanks for testing on Jenkins. It works! 🎉

@jwhitlock jwhitlock merged commit 3a36353 into mdn:master Jun 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@escattone escattone deleted the escattone:fix-jenkins-master-pipeline-1372610 branch Jun 13, 2017

jwhitlock added a commit to mozilla/kuma that referenced this pull request Jun 13, 2017

Update KumaScript
* mdn/kumascript#190 - Split WebExtAllExamples from WebExtExamples
* mdn/kumascript#196 - AddonSidebar: Cleanup themes
* mdn/kumascript#197 - AddonSidebar: Add Creating an appealing...
* mdn/kumascript#198 - remove HTML-Element_Navigation
* mdn/kumascript#199 - remove MozillaOnly
* mdn/kumascript#200 - AddonSidebar: Add Android links
* mdn/kumascript#201 - AddonSidebar: Fix relative link
* mdn/kumascript#202 - LocalizationStatusInSection: Link to repo
* mdn/kumascript#203 - SpecName, spec2: Add Pointer Events 2, etc.
* mdn/kumascript#206 - Fix Jenkins pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment