This repository was archived by the owner on Jun 21, 2022. It is now read-only.
bug 866459: Tweak retries and max jobs per process#29
Merged
groovecoder merged 2 commits intoMay 2, 2013
Conversation
Contributor
Author
|
Huh. Travis build failed, but I don't understand why. Seems like it didn't pick up the hirelings module |
Contributor
Author
|
Oh, I see what happened: I didn't have the latest version of that module working in kumascript |
Contributor
|
Spot-check looks good. r+ merge away. |
groovecoder
added a commit
that referenced
this pull request
May 2, 2013
bug 866459: Tweak retries and max jobs per process
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a band-aid fix. It makes the service retry a failed macro 10 times instead of 3, and it allows workers to process 8 jobs instead of 64 before exiting. It also gives me a handle on the server instance from the telnet REPL, so I maybe can do some live debugging.
My working theory is that we're running into some resource limits from cumulative runs. Lowering max jobs should help avoid that, and raising the retries should make failure less likely since the issue seems to be transient.