Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixing incorrect url string in dependency block that was causing ... #4

Merged
merged 1 commit into from May 7, 2012

Conversation

Projects
None yet
3 participants
Contributor

volkanunsal commented Mar 24, 2012

...a parsing error.

@lmorchard lmorchard commented on the diff Mar 24, 2012

package.json
@@ -20,7 +20,7 @@
"lib": "./lib"
},
"dependencies": {
- "pegjs": "git://github.com/lmorchard/pegjs.git#kumascript",
@lmorchard

lmorchard Mar 24, 2012

Contributor

This didn't work for you? Crud. Maybe I messed up the syntax?

I'm pretty sure the "kumascript" branch of my fork of pegjs is needed to make it installable via NPM from github. I don't think the master branch will work.

Kumascript also needs this recent, unreleased commit of pegjs because it provides more context for error messages. Will be interesting to see if tests pass without the "kumascript" branch installed

Contributor

volkanunsal commented Mar 24, 2012

You may be right about that. Initially, pegjs failed for me during npm rebuild and I installed it via commandline. I didn't think it might be pulling from a forked branch. The error message indicated some problem with the preinstall script.

Contributor

lmorchard commented Mar 24, 2012

Yeah, the upstream project isn't quite set up to be installable by npm from a git url in package.json. So, I tried hacking it to work that way in my fork. I submitted a pull request upstream, but it hasn't been accepted yet :/

Of course, I'm also kind of a noob at this package.json / npm thing

Contributor

darkwing commented May 7, 2012

r+

@darkwing darkwing added a commit that referenced this pull request May 7, 2012

@darkwing darkwing Merge pull request #4 from tenaciousflea/patch-1
Fixing incorrect url string in dependency block that was causing ...
cc94252

@darkwing darkwing merged commit cc94252 into mdn:master May 7, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment