New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if selector exists in selectors.json #687

Merged
merged 1 commit into from Apr 24, 2018

Conversation

Projects
None yet
2 participants
@fALKENdk
Contributor

fALKENdk commented Apr 9, 2018

History in: #671

@fALKENdk fALKENdk referenced this pull request Apr 9, 2018

Closed

Update csssyntax.ejs #671

@wbamberg

This comment has been minimized.

Member

wbamberg commented Apr 24, 2018

@fALKENdk , so sorry to be so slow reviewing this. I'll get to it today.

@wbamberg

I've tested that this makes the macro error go away for pages like :matches and ::slotted that don't yet have entries in mdn/data, and spot-checked some other CSS pages to check they are not regressed.

Since this is a fix for an error that's already in production, let's merge it. We should have regression tests for this macro though (but I do hope to replace the macro fairly soon, so I'm not sure it'a worth writing full tests).

@wbamberg wbamberg merged commit 3c264ed into mdn:master Apr 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment