New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wording of vendor prefix note in compat table #806

Merged
merged 1 commit into from Oct 29, 2018

Conversation

Projects
None yet
3 participants
@connorshea
Contributor

connorshea commented Sep 7, 2018

From "Requires the vendor prefix: " to "Implemented with the vendor prefix:" Fixes #651.

I'm not sure if I should edit this file directly or not? :)

Change wording of vendor prefix note in compat table
From "Requires the vendor prefix: " to "Implemented with the vendor prefix:" Fixes #651.

@wbamberg wbamberg requested a review from Elchi3 Oct 26, 2018

@wbamberg wbamberg added the bcd label Oct 26, 2018

@Elchi3

Elchi3 approved these changes Oct 29, 2018

Yes, this looks good to me. Unfortunately, the localizations become out of date with this change, but we have no good mechanism in place to deal with them anyways.

@Elchi3 Elchi3 merged commit 7631fe6 into mdn:master Oct 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@connorshea connorshea deleted the connorshea:patch-1 branch Oct 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment