New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm localize #897

Merged
merged 1 commit into from Oct 1, 2018

Conversation

Projects
None yet
2 participants
@wbamberg
Member

wbamberg commented Sep 28, 2018

Link to macro: https://github.com/mdn/kumascript/blob/master/macros/localize.ejs

Search results for references from pages: https://developer.mozilla.org/en-US/search?kumascript_macros=localize&locale=%2A&topic=none

Search results for internal references: https://github.com/mdn/kumascript/search?utf8=%E2%9C%93&q=localize&type= Please note: there are lots of hits here, which I think are all false positives, but I'd appreciate a second opinion.

@Elchi3

Elchi3 approved these changes Oct 1, 2018 edited

Looks good to me.
All this does is to call https://github.com/mdn/kumascript/blob/master/macros/wiki.localize.ejs which is in fact almost a no-op. (it does output a string, but nothing else). We should kill wiki.localize.ejs as well, but it has some pages calling it still.

@Elchi3 Elchi3 merged commit 5bf9e88 into mdn:master Oct 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment