New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1438889, change bcd head icons to text labels #997

Merged
merged 3 commits into from Nov 21, 2018

Conversation

Projects
None yet
3 participants
@schalkneethling
Copy link
Contributor

schalkneethling commented Nov 19, 2018

KumaScript side of Kuma mozilla/kuma#5117 ~ @Elchi3 r?

@jwhitlock
Copy link
Member

jwhitlock left a comment

Just enough to implement the feature, and tests as well! Thanks, @schalkneethling!

@Elchi3

This comment has been minimized.

Copy link
Member

Elchi3 commented Nov 21, 2018

One more change that would be good to get in here now that we actually display the browser names:

"iOS Safari" should be "Safari on iOS" (request from @apple-web-evangelist)

@schalkneethling

This comment has been minimized.

Copy link
Contributor

schalkneethling commented Nov 21, 2018

@Elchi3 "Safari on iOS" or "Safari for iOS"? - Just wanted to double check.

@Elchi3

This comment has been minimized.

Copy link
Member

Elchi3 commented Nov 21, 2018

Might have been "Safari for iOS", maybe @atopal remembers, otherwise maybe @apple-web-evangelist can comment ? :)

@jwhitlock

This comment has been minimized.

Copy link
Member

jwhitlock commented Nov 21, 2018

Might have been "Safari for iOS", maybe @atopal remembers, otherwise maybe @apple-web-evangelist can comment ? :)

developer.apple.com uses Safari on iOS and never Safari for iOS. Let's go with "Safari on iOS".

@schalkneethling

This comment has been minimized.

Copy link
Contributor

schalkneethling commented Nov 21, 2018

@jwhitlock @Elchi3 updated to Safari on iOS

@jwhitlock
Copy link
Member

jwhitlock left a comment

@jwhitlock jwhitlock merged commit bed8b7f into mdn:master Nov 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment