New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified console message to understand flow #10

Merged
merged 4 commits into from Nov 1, 2018

Conversation

Projects
None yet
2 participants
@lordloh
Copy link
Contributor

lordloh commented Oct 31, 2018

Added

Main:
Worker:

to make console message look like a dialog.

@chrisdavidmills

This comment has been minimized.

Copy link
Contributor

chrisdavidmills commented Oct 31, 2018

Hi there! This is quite a good idea for making the flow easier to understand. The only thing I'd change is to surround the relevant event handlers, e.g. [first.onchange] in regular parentheses instead, e.g. (first.onchange) — I say this because when I first saw it, my mind instantly started thinking that it was related to an array in some way.

@lordloh

This comment has been minimized.

Copy link
Contributor

lordloh commented Oct 31, 2018

Done :-) Should I also make a pull request for master branch?

@chrisdavidmills chrisdavidmills merged commit 4eecdc0 into mdn:gh-pages Nov 1, 2018

@chrisdavidmills

This comment has been minimized.

Copy link
Contributor

chrisdavidmills commented Nov 1, 2018

Perfect! We can merge this from here.....done. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment