Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken link (Push API Demo) #11054

Merged
merged 2 commits into from Jan 28, 2023
Merged

Broken link (Push API Demo) #11054

merged 2 commits into from Jan 28, 2023

Conversation

Rishav1707
Copy link
Contributor

This PR fixes the following issue:

fixes #10968

Changes made:

  • Replace the broken link with the new link.

@Rishav1707 Rishav1707 requested a review from a team as a code owner January 11, 2023 10:55
@Rishav1707 Rishav1707 requested review from josielrocha and removed request for a team January 11, 2023 10:55
@github-actions github-actions bot added the l10n-pt-br Issues related to Brazilian Portuguese label Jan 11, 2023
@Rishav1707
Copy link
Contributor Author

Please review my changes...

@Rishav1707
Copy link
Contributor Author

Please review my changes...

?? @marcos-segantine

@Rishav1707
Copy link
Contributor Author

@josielrocha Please review my changes...

@Rishav1707
Copy link
Contributor Author

Please review my changes @josielrocha

@josielrocha josielrocha merged commit 7f18649 into mdn:main Jan 28, 2023
@josielrocha
Copy link
Collaborator

Thank you for your help @Rishav1707!

@github-actions
Copy link
Contributor

Preview URLs

Flaws (22)

URL: /pt-BR/docs/Web/API/Push_API
Title: API Push
Flaw count: 22

  • macros:
    • /pt-BR/docs/Web/API/PushManager/subscribe does not exist but fell back to /en-US/docs/Web/API/PushManager/subscribe
    • /pt-BR/docs/Web/API/PushSubscription does not exist but fell back to /en-US/docs/Web/API/PushSubscription
    • /pt-BR/docs/Web/API/ServiceWorkerGlobalScope/onpush does not exist
    • /pt-BR/docs/Web/API/ServiceWorkerRegistration/showNotification does not exist but fell back to /en-US/docs/Web/API/ServiceWorkerRegistration/showNotification
    • /pt-BR/docs/Web/API/PushEvent does not exist but fell back to /en-US/docs/Web/API/PushEvent
    • and 12 more flaws omitted
  • broken_links:
    • Can't resolve /pt-BR/docs/Web/API/Simple_Push_API
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Link points to the page it's already on
  • translation_differences:
    • Differences in the important macros (2 in common of 4 possible)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcos-segantine marcos-segantine marcos-segantine approved these changes

@josielrocha josielrocha Awaiting requested review from josielrocha

Assignees
No one assigned
Labels
l10n-pt-br Issues related to Brazilian Portuguese
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken link (Push API Demo) - Brazilian Portuguese version of the page
3 participants
@Rishav1707 @josielrocha @marcos-segantine