New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed editable-list example bug #13

Merged
merged 4 commits into from Nov 27, 2018

Conversation

Projects
None yet
2 participants
@liuxuewei
Copy link

liuxuewei commented Nov 27, 2018

fix bug: when remove a list item , 'list-item' dom will be removed after add item

@chrisdavidmills chrisdavidmills merged commit cda194a into mdn:master Nov 27, 2018

@chrisdavidmills

This comment has been minimized.

Copy link
Contributor

chrisdavidmills commented Nov 27, 2018

I'm not sure if this exactly fixes a bug, but it does make the code far simpler — it adds the event listener to the button for the added list item only, rather than trying to add the listener to all the list items every time.

@chrisdavidmills

This comment has been minimized.

Copy link
Contributor

chrisdavidmills commented Nov 27, 2018

Thanks for the contributon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment