New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the synthesis demo, put the voices into alphabetical order, ignoring case #30

Merged
merged 1 commit into from Nov 22, 2018

Conversation

Projects
None yet
2 participants
@c12h
Copy link
Contributor

c12h commented Nov 21, 2018

This makes experimenting with the synthesis demo more convenient, at least for me,

@chrisdavidmills

This comment has been minimized.

Copy link
Contributor

chrisdavidmills commented Nov 21, 2018

I don't really see that this change makes much difference. Can you describe to me what the difference in output is?

@c12h

This comment has been minimized.

Copy link
Contributor

c12h commented Nov 22, 2018

Sorry, I did not explain well. This makes no difference to output, it only changes part of the UI to make it more convenient to see what voices are available, for those of us who want to hear the different voices.

@chrisdavidmills

This comment has been minimized.

Copy link
Contributor

chrisdavidmills commented Nov 22, 2018

Ah! Now I get it! It sorts the voices into alphabetical order. This was not as obvious in Firefox, but much more obvious in Chrome as it includes the default Google voices, which without your sort code are lumped at the end of the list.

Yeah, I like this — merging.

@chrisdavidmills chrisdavidmills merged commit bb0120e into mdn:master Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment