New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nits #20

Merged
merged 1 commit into from Oct 17, 2018

Conversation

Projects
None yet
3 participants
@stoyan
Contributor

stoyan commented Oct 17, 2018

arrow functions, vars/let/const, ' vs ", tabs vs spaces (I know! In my defence there was a mix of both, so one won :)), less this, ran eslint, stylelint

nits
arrow functions, vars/let/const, ' vs ", tabs vs spaces (I know! In my defence there was a mix of both, so one won :)), less `this`, ran eslint, csslint
@stoyan

This comment has been minimized.

Contributor

stoyan commented Oct 17, 2018

@chrisdavidmills

This comment has been minimized.

Contributor

chrisdavidmills commented Oct 17, 2018

These updates look OK to me, thanks @stoyan. @Rumyra , are you happy for me to merge this, or did you have any comments?

@Rumyra

This comment has been minimized.

Contributor

Rumyra commented Oct 17, 2018

This looks good to me!

I noticed the tabs vs spaces but also noticed one didn't win - I'm curious to know which one @stoyan chose ;)

@chrisdavidmills chrisdavidmills merged commit f802f38 into mdn:master Oct 17, 2018

@chrisdavidmills

This comment has been minimized.

Contributor

chrisdavidmills commented Oct 17, 2018

Cool, merged.

Looks like spaces to me, which is good as that's standard MDN style.

@stoyan

This comment has been minimized.

Contributor

stoyan commented Oct 17, 2018

well, technically there were more tabs than spaces, I think, but spaces somehow miraculously won :)

Thanks for the code and the articles, @Rumyra, they're priceless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment