From 1dd4504dd0b11813c53e97bad8c602cafdbcf5ad Mon Sep 17 00:00:00 2001 From: Richard Bloor Date: Mon, 2 Oct 2023 11:06:04 +1300 Subject: [PATCH 1/2] Reverse var to let change --- root-cert-stats/background.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/root-cert-stats/background.js b/root-cert-stats/background.js index 272fedad..59c70f34 100644 --- a/root-cert-stats/background.js +++ b/root-cert-stats/background.js @@ -1,6 +1,6 @@ "use strict"; -let rootCertStats = {}; +var rootCertStats = {}; /* On an onHeadersReceived event, if there was a successful TLS connection From cf28d621a512e2182a9577e2e259b2b7b4eacdb8 Mon Sep 17 00:00:00 2001 From: rebloor Date: Mon, 2 Oct 2023 13:39:42 +1300 Subject: [PATCH 2/2] Review feedback Co-authored-by: Rob Wu --- root-cert-stats/background.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/root-cert-stats/background.js b/root-cert-stats/background.js index 59c70f34..24edf50e 100644 --- a/root-cert-stats/background.js +++ b/root-cert-stats/background.js @@ -1,5 +1,8 @@ "use strict"; +// Note: declared with "var" because popup.js references this global variable. +// If this were to be declared with "const" or "let", then the variable would +// still be available to this file, but not to popup.js. var rootCertStats = {}; /*