Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using <Link> instead of <a> in main-menu.tsx for non-externals #872

Open
peterbe opened this issue Jul 9, 2020 · 3 comments
Open
Labels
🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up. needs: discussion p4 Not urgent, only if time allows 🚉 platform keeping the platform healthy

Comments

@peterbe
Copy link
Contributor

peterbe commented Jul 9, 2020

Just a note to remember to play with this.

@peterbe
Copy link
Contributor Author

peterbe commented Sep 23, 2020

The task is actually to decide if client-side navigation is better than regular navigation.
It's a delicate quest that has one foot in web performance and one foot in a11y.
Whatever we decide, if the evidence is good, we should consider this for the other places where we use <Link> which is the breadcrumbs and the autocomplete search results.

@peterbe
Copy link
Contributor Author

peterbe commented Oct 30, 2020

@schalkneethling Given the potential improvements to the <Link> with the <PreloadingDocumentLink> component we might reconsider.
We'd need to be aware of this for each link in the header. I.e. whether it links to a document or to some other page that doesn't have a index.json state file.

@Ryuno-Ki
Copy link

Ryuno-Ki commented Nov 3, 2020

How does <Link> behave with context actions (save Link As…, Open Link in New Tab etc)?
Can I drag a link to the URL bar and have it opened?

Since you mentioned accessibility (a11y for short), here are the relevant sections from WAI-ARIA:
https://www.w3.org/TR/wai-aria-practices/#link and https://www.w3.org/TR/wai-aria-1.1/#link

@schalkneethling schalkneethling added 🚉 platform keeping the platform healthy and removed Post-launch labels Nov 2, 2021
@github-actions github-actions bot added the 🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up. label Dec 9, 2021
@caugner caugner added p4 Not urgent, only if time allows needs: discussion labels Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up. needs: discussion p4 Not urgent, only if time allows 🚉 platform keeping the platform healthy
Projects
Development

No branches or pull requests

4 participants