From 03f565bb895188df3f9f6f907e1f67f721284b8c Mon Sep 17 00:00:00 2001 From: Mario Domgoergen Date: Fri, 25 Jan 2019 21:09:38 +0100 Subject: [PATCH] Precompute preserve_whitespace and use short-circuit to optimze test --- lib/App/termpub/Renderer.pm | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/App/termpub/Renderer.pm b/lib/App/termpub/Renderer.pm index 92d8747..9daf332 100644 --- a/lib/App/termpub/Renderer.pm +++ b/lib/App/termpub/Renderer.pm @@ -168,8 +168,9 @@ sub textnode { } my $buffer; - my $left_margin = $self->left_margin; - my $columns = $self->columns; + my $left_margin = $self->left_margin; + my $columns = $self->columns; + my $reduce_whitespace = !$self->preserve_whitespace; for my $word (@words) { my $length = length($word); @@ -183,10 +184,7 @@ sub textnode { next; } - next - if $self->column == 0 - && $word =~ /^\s+$/ - && !$self->preserve_whitespace; + next if $reduce_whitespace && $self->column == 0 && $word =~ /^\s+$/; if ( $left_margin && $self->column == 0 ) { my ( $row, $column );