Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
add make environment and other files from cpan and adding a changes file #6
I appreciate the time you took to do this; I know that these things take effort.
However, there are a number of issues with your pull request, some superficial and some fundamental, that mean I will not accept it or anything much like it.
Most superficially, your description is both incorrect and unclear. Incorrect in that if I look at your change, it does not add a changes file. Unclear in that I don't understand what you mean by "add make environment and other files from cpan", but as far as I can tell, it doesn't do that either.
Fundamentally, I think you have misunderstood that the CPAN distribution is generated from these files, using Dist::Zilla, and thus it would not be appropriate to merge in the generated files. I have, historically, kept a branch ('upstream') that contains the generated files, too, which I neglected to update when I made the latest release; I will try to find the time to address that for this latest release. But this would not be the way to go about resolving that---your branch loses information about the provenance of that branch.
So while I do acknowledge your effort, I'm afraid I'm not going to be merging this.