New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add make environment and other files from cpan and adding a changes file #6

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@thaabit

thaabit commented Feb 6, 2015

I copied the files from CPAN and put them into the git branch as well as adding a changes file. This is my first time doing this so let me know what you think. The POD was interleaved on git but at the bottom on CPAN.

  • Garth
@mdorman

This comment has been minimized.

Owner

mdorman commented Feb 7, 2015

I appreciate the time you took to do this; I know that these things take effort.

However, there are a number of issues with your pull request, some superficial and some fundamental, that mean I will not accept it or anything much like it.

Most superficially, your description is both incorrect and unclear. Incorrect in that if I look at your change, it does not add a changes file. Unclear in that I don't understand what you mean by "add make environment and other files from cpan", but as far as I can tell, it doesn't do that either.

Fundamentally, I think you have misunderstood that the CPAN distribution is generated from these files, using Dist::Zilla, and thus it would not be appropriate to merge in the generated files. I have, historically, kept a branch ('upstream') that contains the generated files, too, which I neglected to update when I made the latest release; I will try to find the time to address that for this latest release. But this would not be the way to go about resolving that---your branch loses information about the provenance of that branch.

So while I do acknowledge your effort, I'm afraid I'm not going to be merging this.

@mdorman mdorman closed this Feb 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment