Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when using --enable-frozen-string-literal Ruby option #95

Merged
merged 1 commit into from Apr 23, 2020

Conversation

@jeremyevans
Copy link
Contributor

jeremyevans commented Apr 22, 2020

No description provided.

mdp added a commit that referenced this pull request Apr 22, 2020
- Fix issue when using --enable-frozen-string-literal Ruby option #95
  (jeremyevans)
- Update gems (rake, addressable)
  - Updated gems removes support for Ruby <2.5. Seeing as 2.3 is now
    longer getting security patches, this seems like a non-issue
This was referenced Apr 22, 2020
@mdp
Copy link
Owner

mdp commented Apr 22, 2020

Thanks Jeremy,

If you're OK with it, I'm moving this into a major version bump where I'm also updating the dependencies (which removed support for ruby <2.3, hence the major bump)

#97

If that all looks good, I'll push this out tonight or tomorrow.

@jeremyevans
Copy link
Contributor Author

jeremyevans commented Apr 22, 2020

Sure, that sounds good to me. Thank you for the quick response!

mdp added a commit that referenced this pull request Apr 23, 2020
- Version bump to 6.0.0 due to Ruby support change
- Updated 'addressable' and 'rake' gems

Squashed commit of the following:

commit 95e4873
Author: Mark Percival <m@mdp.im>
Date:   Thu Apr 23 15:35:15 2020 +0000

    Update Changelog about travis ruby addition

commit f252777
Author: Mark Percival <m@mdp.im>
Date:   Wed Apr 22 17:47:03 2020 +0000

    Major bump

commit 191ef03
Author: Mark Percival <m@mdp.im>
Date:   Wed Apr 22 17:35:50 2020 +0000

    Add back in 2.3

    2.3 has been EOL'd, but it still compatible with this gems dependencies

commit bafe8bf
Author: Mark Percival <m@mdp.im>
Date:   Wed Apr 22 17:12:59 2020 +0000

    Remove Travis ruby test for 2.0

commit 0919196
Author: Mark Percival <m@mdp.im>
Date:   Wed Apr 22 17:08:45 2020 +0000

    Frozen string fix, updated deps, ruby deprecation

    - Fix issue when using --enable-frozen-string-literal Ruby option #95
      (jeremyevans)
    - Update gems (rake, addressable)
      - Updated gems removes support for Ruby <2.5. Seeing as 2.3 is now
        longer getting security patches, this seems like a non-issue
@mdp mdp merged commit 5ec60df into mdp:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.