pci: force minimum mem bar alignment of 64K for board-qemu

This is needed to ensure VFIO passthrough devices are able to offload MMIO accesses to KVM. Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
mdroth · Feb 27, 2017 · 6ff6827 · 6ff6827
1 parent efd65f4
commit 6ff6827
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 6 deletions.
diff --git a/board-qemu/slof/pci-phb.fs b/board-qemu/slof/pci-phb.fs
@@ -331,6 +331,7 @@ setup-puid
    my-puid TO puid                  \ Set current puid
    phb-parse-ranges
    1 TO pci-hotplug-enabled
+   10000 TO pci-mem-bar-min-align   \ Force 64k alignment for all mem BARs
    s" qemu,phb-enumerated" get-node get-property 0<> IF
        1 0 (probe-pci-host-bridge)
    ELSE

diff --git a/slof/fs/pci-properties.fs b/slof/fs/pci-properties.fs
@@ -91,15 +91,39 @@
 \ ***************************************************************************************
 \ align the current mem and set var to next mem
 \ align with a size of 0 returns 0 !!!
+: assign-var-min-align ( size var min-align -- al-mem )
+        rot                             \ ( var min-align size )
+        2dup < IF                       \ IF size > min-align
+            swap drop dup               \ ( var size align )
+        ELSE
+            swap                        \ ( var size align )
+        THEN
+        rot                             \ ( size align var )
+        dup @                           \ ( size align var cur-mem ) read current free mem
+        rot                             \ ( size var cur-mem align )
+        #aligned                        \ ( size var al-mem )        align the mem to the size
+        dup 2swap -rot +                \ ( al-mem var new-mem )     add size to aligned mem
+        swap !                          \ ( al-mem )                 set variable to new mem
+;
+
 : assign-var ( size var -- al-mem )
-        2dup @                          \ ( size var size cur-mem ) read current free mem
-        swap #aligned                   \ ( size var al-mem )       align the mem to the size
-        dup 2swap -rot +                \ ( al-mem var new-mem )    add size to aligned mem
-        swap !                          \ ( al-mem )                set variable to new mem
+        0 assign-var-min-align
 ;
 
 \ set bar to current free mem ( in variable ) and set variable to next free mem
 : assign-bar-value32 ( bar size var -- 4 )
+        over IF                         \ IF size > 0
+                pci-mem-bar-min-align
+                assign-var-min-align    \ | ( bar al-mem ) set variable to next mem
+                swap rtas-config-l!     \ | ( -- )         set the bar to al-mem
+        ELSE                            \ ELSE
+                2drop drop              \ | clear stack
+        THEN                            \ FI
+        4                               \ size of the base-address-register
+;
+
+\ set bar to current free mem ( in variable ) and set variable to next free mem
+: assign-io-bar-value32 ( bar size var -- 4 )
         over IF                         \ IF size > 0
                 assign-var              \ | ( bar al-mem ) set variable to next mem
                 swap rtas-config-l!     \ | ( -- )         set the bar to al-mem
@@ -112,7 +136,8 @@
 \ set bar to current free mem ( in variable ) and set variable to next free mem
 : assign-bar-value64 ( bar size var -- 8 )
         over IF                         \ IF size > 0
-                assign-var              \ | ( bar al-mem ) set variable to next mem
+                pci-mem-bar-min-align
+                assign-var-min-align    \ | ( bar al-mem ) set variable to next mem
                 swap                    \ | ( al-mem addr ) calc config-addr of this bar
                 2dup rtas-config-l!     \ | ( al-mem addr ) set the Lower part of the bar to al-mem
                 4 + swap 20 rshift      \ | ( al-mem>>32 addr ) prepare the upper part of the al-mem
@@ -163,7 +188,7 @@
 : assign-io-bar ( bar-addr -- 4 )
         dup pci-bar-size-io             \ fetch size
         pci-next-io                     \ var to change
-        assign-bar-value32              \ and set it all
+        assign-io-bar-value32           \ and set it all
 ;
 
 \ Setup an Expansion ROM bar

diff --git a/slof/fs/pci-scan.fs b/slof/fs/pci-scan.fs
@@ -24,6 +24,9 @@ VARIABLE pci-max-io
 VARIABLE pci-next-mem64           \ prefetchable 64-bit memory mapped
 VARIABLE pci-max-mem64
 
+\ 0 to default to natural alignment
+0 VALUE pci-mem-bar-min-align
+
 \ Counter of busses found
 0 VALUE pci-bus-number
 \ Counter of devices found