Add time constraint between signature and verification #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eraffel-MDSol
force-pushed
the
feature/VerifySignatureTime
branch
from
88d14ae
to
25c8b89
Compare
johnduhart
reviewed
Mar 21, 2023
Comment on lines
+117
to
+120
| if (!IsSignatureTimeValid(authInfo.SignedTime)) | ||
| { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
In my Go implementation I put this check before the public key lookup given it's a cheap check.
|
@mdsol/enablement-dotnet |
prajon84
reviewed
Mar 21, 2023
|
|
||
| if (!IsSignatureTimeValid(authInfo.SignedTime)) | ||
| { | ||
| return false; |
There was a problem hiding this comment.
Do we need to throw TimeOutException and log error similar to other cases ?
There was a problem hiding this comment.
I don't think we throw an exception if verification of the signature fails, so I'm not sure why we would throw an exception here either.
There was a problem hiding this comment.
How about a log though? If I had to debug why? Not sure how logging is throughout this library.
There was a problem hiding this comment.
Yeah at least a logger would be beneficial too.
eraffel-MDSol
force-pushed
the
feature/VerifySignatureTime
branch
from
5709e13
to
bf7b848
Compare
Jman420
requested changes
Mar 22, 2023
|
|
||
| if (!IsSignatureTimeValid(authInfo.SignedTime)) | ||
| { | ||
| return false; |
Jman420
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.