Use Ruby 2.0.0 for all Travis builds #5

Merged
merged 1 commit into from Apr 6, 2013

Projects

None yet

2 participants

@jessieay
Contributor
jessieay commented Apr 5, 2013
  • Old travis.yml used ruby 2.0.0 for one build, 1.9.3 (default) for rest
  • New travis.yml more clearly shows ruby version being tested against
  • Add travis build status badge to README
  • View of new output: https://travis-ci.org/jessieay/sham_rack/
Jessie Young Use Ruby 2.0.0 for all Travis builds
* Old travis.yml used ruby 2.0.0 for one build, 1.9.3 (default) for rest
* New travis.yml more clearly shows ruby version being tested against
* Add travis build status badge to README
* View of new output: https://travis-ci.org/jessieay/sham_rack/builds/6092942
aeb0ecd
@mdub
Owner
mdub commented Apr 5, 2013

Hi Jessie.

The Travis badge in the README is a good idea, thanks.

I'm not so keen on the ".travis.yml" changes. The idea was to have a "baseline" using Travis's default Ruby (1.9.3) and the latest version of Rack, then have the other builds vary either the Ruby version or the Rack version, but not both. I'm not sure I want to run ALL the builds on Ruby 2.

Are there particular build configurations that you think are missing?

@jessieay
Contributor
jessieay commented Apr 5, 2013

Hi @mdub - the reason I submitted the PR is that it took some digging to within Travis to find which version of Ruby you were testing against. Of course, I could get that information from the ".travis.yml" file, but your configuration in there is slightly unusual so I wasn't 100% sure of what versions were being tested.

Would you be opposed to testing each of the specified Rack versions against both 1.9.3 and 2.0.0? That way, we could have the baseline test that you mentioned in your comment. I myself was looking at Travis to make sure sham_rack is Ruby 2 compatible, and with the previous configuration it was difficult to tell which builds were using which Ruby versions.

If that is OK with you, I will update the PR accordingly.

@mdub
Owner
mdub commented Apr 6, 2013

Fair enough. Okay, I'll merge this PR, and update the travis config to use 1.9.3 as well.

@mdub mdub merged commit ef0bac4 into mdub:master Apr 6, 2013

1 check failed

default The Travis build failed
Details
@jessieay
Contributor
jessieay commented Apr 8, 2013

Awesome - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment