From cedb1c7aa73b9404c218fa53cbca69b293be89ca Mon Sep 17 00:00:00 2001
From: Peter Veentjer <alarmnummer@gmail.com>
Date: Wed, 3 Apr 2019 10:52:22 +0200
Subject: [PATCH] MetricsRegistry unregister fix.

NioNetworking can be stopped and started. When this happens, the
IOThreads get re-registered and will overwrite the old probes. This
causes logging noise.

This PR fixes this problem by deregistering the IOThreads when NioNetworking
is shutdown.

(cherry picked from commit 4d9c28e741d3d77ba39021ab06c30191bf52297b)
---
 .../com/hazelcast/internal/networking/nio/NioNetworking.java    | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hazelcast/src/main/java/com/hazelcast/internal/networking/nio/NioNetworking.java b/hazelcast/src/main/java/com/hazelcast/internal/networking/nio/NioNetworking.java
index 5f314dc45fb8..6962819a90e0 100644
--- a/hazelcast/src/main/java/com/hazelcast/internal/networking/nio/NioNetworking.java
+++ b/hazelcast/src/main/java/com/hazelcast/internal/networking/nio/NioNetworking.java
@@ -230,6 +230,7 @@ public void shutdown() {
         shutdown(outputThreads);
         outputThreads = null;
         closeListenerExecutor.shutdown();
+        metricsRegistry.deregister(ioBalancer);
     }
 
     private void shutdown(NioThread[] threads) {
@@ -238,6 +239,7 @@ private void shutdown(NioThread[] threads) {
         }
         for (NioThread thread : threads) {
             thread.shutdown();
+            metricsRegistry.deregister(thread);
         }
     }