Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove deprecated functions, test coverage 100% #35

Merged
merged 1 commit into from Aug 11, 2019
Merged

Conversation

@JounQin
Copy link
Member

JounQin commented Aug 11, 2019

No description provided.

@JounQin JounQin added the internal label Aug 11, 2019
@JounQin JounQin added this to the 1.0 milestone Aug 11, 2019
@JounQin JounQin self-assigned this Aug 11, 2019
@JounQin JounQin added this to In progress in RoadMap via automation Aug 11, 2019
@JounQin JounQin force-pushed the develop branch from a346b83 to c6fd301 Aug 11, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 11, 2019

Codecov Report

Merging #35 into master will increase coverage by 1.6%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #35     +/-   ##
=======================================
+ Coverage   98.39%   100%   +1.6%     
=======================================
  Files          15     16      +1     
  Lines         312    310      -2     
  Branches       63     58      -5     
=======================================
+ Hits          307    310      +3     
+ Partials        5      0      -5
Impacted Files Coverage Δ
packages/eslint-plugin-mdx/src/index.ts 100% <ø> (ø)
packages/eslint-mdx/src/parser.ts 100% <ø> (+3.5%) ⬆️
packages/eslint-mdx/src/regexp.ts 100% <100%> (ø) ⬆️
packages/eslint-mdx/src/helper.ts 100% <100%> (ø) ⬆️
test/helper.ts 100% <100%> (ø) ⬆️
...lint-plugin-mdx/src/rules/no-unescaped-entities.ts 100% <0%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a0a906...f69b263. Read the comment docs.

@JounQin JounQin force-pushed the develop branch 2 times, most recently from 677c2f4 to d89839a Aug 11, 2019
@JounQin JounQin force-pushed the develop branch from d89839a to f69b263 Aug 11, 2019
@JounQin JounQin merged commit d04db57 into master Aug 11, 2019
4 checks passed
4 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 98.39%)
Details
codecov/project 100% (+1.6%) compared to 2a0a906
Details
RoadMap automation moved this from In progress to Done Aug 11, 2019
@JounQin JounQin deleted the develop branch Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
RoadMap
  
Done
1 participant
You can’t perform that action at this time.