Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce syntax highlighting #1140

Merged
merged 3 commits into from
Jul 13, 2020
Merged

Introduce syntax highlighting #1140

merged 3 commits into from
Jul 13, 2020

Conversation

samrobbins85
Copy link
Contributor

Add code syntax highlighting

Before:
image

After:

image

Add code syntax highlighting
@vercel
Copy link

vercel bot commented Jul 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mdx/mdx/n2t5ij3rd
✅ Preview: https://mdx-git-fork-samrobbins85-patch-1.mdx.vercel.app

@vercel vercel bot temporarily deployed to Preview July 11, 2020 19:34 Inactive
@samrobbins85 samrobbins85 changed the title Update code-block.js Introduce syntax highlighting Jul 11, 2020
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💯

@samrobbins85
Copy link
Contributor Author

Just checking if I need to try and resolve the CI errors for this to merge, as I don't believe the issues relate to the patch I have proposed?

@JounQin
Copy link
Member

JounQin commented Jul 13, 2020

@samrobbins85 There are two lint errors introduced by your PR. (Ignore the remark warnings, they are tracking at mdx-js/eslint-mdx#217)

Fix eslint errors
@vercel vercel bot temporarily deployed to Preview July 13, 2020 08:18 Inactive
@vercel vercel bot temporarily deployed to Preview July 13, 2020 08:23 Inactive
@JounQin JounQin merged commit f9340f4 into mdx-js:master Jul 13, 2020
@samrobbins85 samrobbins85 deleted the patch-1 branch July 13, 2020 09:58
wooorm pushed a commit that referenced this pull request Dec 17, 2020
* Update code-block.js

Add code syntax highlighting

* Update code-block.js

Fix eslint errors

* Second fix of eslint errors
wooorm pushed a commit that referenced this pull request Dec 17, 2020
* Update code-block.js

Add code syntax highlighting

* Update code-block.js

Fix eslint errors

* Second fix of eslint errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants