Skip to content

Exclude export const/let/var/function from default check #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2018
Merged

Exclude export const/let/var/function from default check #349

merged 1 commit into from
Dec 8, 2018

Conversation

@timneutkens
Copy link
Member

@timneutkens timneutkens commented Dec 8, 2018 •
edited
Loading

We ran into this on a blogpost on zeit.co

@vercel
Copy link

vercel bot commented Dec 8, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@timneutkens timneutkens requested review from johno and silvenon December 8, 2018 19:10
johno
johno approved these changes Dec 8, 2018
View reviewed changes
Copy link
Member

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌳

@johno johno merged commit f79665c into mdx-js:master Dec 8, 2018
@timneutkens timneutkens deleted the fix/loader-error branch December 8, 2018 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johno johno johno approved these changes

@silvenon silvenon Awaiting requested review from silvenon

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timneutkens @johno