Skip to content

Exclude export const/let/var/function from default check #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2018
Merged

Exclude export const/let/var/function from default check #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/mdx/mdx-hast-to-jsx.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ function toJSX(node, parentNode = {}, options = {}) {

if (
/\bdefault\b/.test(childNode.value) &&
!/default\s+as/.test(childNode.value)
!/default\s+as/.test(childNode.value) &&
!/^export (const|let|var|function)/.test(childNode.value)
) {
let example

Expand Down
6 changes: 6 additions & 0 deletions packages/mdx/test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,12 @@ it('Should support semicolons in default export statement', async () => {
it('Should throw when exporting default via named export', async () => {
await expect(mdx(`export { default } from './Layout'`)).rejects.toThrow()
await expect(mdx(`export { Layout as default }`)).rejects.toThrow()

// Edge case where user has the text "default" as part of the export node
await mdx(`export const meta = {
description: 'better default behavior.'
}`)

await expect(
mdx(`export { default as MyComp } from './MyComp'`)
).resolves.toContain(`export { default as MyComp } from './MyComp'`)
Expand Down