Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate with `eslint-mdx` to lint `.mdx` with `ESLint`, ready for reviewing #726

Merged
merged 3 commits into from Aug 14, 2019

Conversation

@JounQin
Copy link
Member

JounQin commented Aug 11, 2019

eslint-mdx is a ESLint Parser/Plugin for MDX, helps you lint all ES syntaxes excluding code block of course. Work perfectly with eslint-plugin-import, eslint-plugin-prettier or any other eslint plugins.

It is a complete rewriting from scratch for eslint-plugin-mdx.

@now

This comment has been minimized.

Copy link

now bot commented Aug 11, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://mdx-git-fork-jounqin-patch-1.mdx.now.sh

@JounQin JounQin changed the title docs: Add `eslint-mdx` into document [Draft] docs: Add `eslint-mdx` into document Aug 11, 2019
@now now bot temporarily deployed to staging Aug 11, 2019 Inactive
@JounQin JounQin changed the title [Draft] docs: Add `eslint-mdx` into document feat: integrate with `eslint-mdx` to lint `.mdx` with `ESLint`, ready for reviewing Aug 11, 2019
@wooorm wooorm mentioned this pull request Aug 12, 2019
@johno
johno approved these changes Aug 13, 2019
Copy link
Member

johno left a comment

This is amazing @JounQin! Do you mind fixing the conflict in yarn.lock and then I can merge?

JounQin added 3 commits Aug 11, 2019
ESLint Parser/Plugin for MDX, helps you lint all ES syntaxes excluding `code` block of course. Work perfectly with `eslint-plugin-import`, `eslint-plugin-prettier` or any other eslint plugins.

It is a complete rewriting from scratch for [eslint-plugin-mdx](https://github.com/azz/eslint-plugin-mdx).
@JounQin

This comment has been minimized.

Copy link
Member Author

JounQin commented Aug 13, 2019

@johno Done. THX for reviewing.

@johno

This comment has been minimized.

Copy link
Member

johno commented Aug 14, 2019

Thanks!

@johno johno merged commit bfe31e8 into mdx-js:master Aug 14, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
now Deployment has completed
Details
@JounQin JounQin deleted the JounQin:patch-1 branch Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.