Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace remark-cli with eslint-plugin-mdx #744

Merged
merged 2 commits into from Aug 30, 2019
Merged

Conversation

@JounQin
Copy link
Member

JounQin commented Aug 22, 2019

Motivation: remark-lint is great, and we have been using ESLint with it together, but it is redundant to lint .mdx twice by two separate tools, so I added support for linting markdown syntax by remark plugins of course inside eslint-plugin-mdx.

What means we can reduce devDependencies and simplify linting usage as my PR changes.


related: @rxts/eslint-plugin-mdx has been renamed to eslint-plugin-mdx, thanks to @azz

@now

This comment has been minimized.

Copy link

now bot commented Aug 22, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://mdx-git-fork-rx-ts-feat-eslint.mdx.now.sh

@JounQin

This comment has been minimized.

Copy link
Member Author

JounQin commented Aug 27, 2019

@johno Would you like to review this PR or give some feedback?

@johno johno requested review from wooorm and silvenon Aug 27, 2019
@wooorm

This comment has been minimized.

Copy link
Member

wooorm commented Aug 28, 2019

Hey @JounQin, people typically explain why they are creating a PR. In fact, we have a template for that, but you didn’t use it.

Could you give us info on what this does and why it should land?

@JounQin

This comment has been minimized.

Copy link
Member Author

JounQin commented Aug 28, 2019

@wooorm Sorry I ignored the comment, I will finish that part soon later.

@JounQin

This comment has been minimized.

Copy link
Member Author

JounQin commented Aug 28, 2019

@wooorm Please review the PR description again.

Copy link
Contributor

silvenon left a comment

⭐️

@wooorm
wooorm approved these changes Aug 30, 2019
Copy link
Member

wooorm left a comment

Alright, looks good!

JounQin added 2 commits Aug 22, 2019
related: @rxts/eslint-plugin-mdx has been renamed to eslint-plugin-mdx. thanks to @azz
@johno

This comment has been minimized.

Copy link
Member

johno commented Aug 30, 2019

Thanks @JounQin!

@johno johno merged commit 67d9cd8 into mdx-js:master Aug 30, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
now Deployment has completed
Details
@JounQin JounQin deleted the rx-ts:feat/eslint branch Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.