Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfeat: replace remark-cli with eslint-plugin-mdx #744
Conversation
This comment has been minimized.
This comment has been minimized.
now
bot
commented
Aug 22, 2019
•
This pull request is automatically deployed with Now. Latest deployment for this branch: https://mdx-git-fork-rx-ts-feat-eslint.mdx.now.sh |
This comment has been minimized.
This comment has been minimized.
@johno Would you like to review this PR or give some feedback? |
This comment has been minimized.
This comment has been minimized.
Hey @JounQin, people typically explain why they are creating a PR. In fact, we have a template for that, but you didn’t use it. Could you give us info on what this does and why it should land? |
This comment has been minimized.
This comment has been minimized.
@wooorm Sorry I ignored the comment, I will finish that part soon later. |
This comment has been minimized.
This comment has been minimized.
@wooorm Please review the PR description again. |
|
Alright, looks good! |
This comment has been minimized.
This comment has been minimized.
Thanks @JounQin! |
JounQin commentedAug 22, 2019
•
edited
Motivation:
remark-lint
is great, and we have been usingESLint
with it together, but it is redundant to lint.mdx
twice by two separate tools, so I added support for linting markdown syntax byremark
plugins of course insideeslint-plugin-mdx
.What means we can reduce devDependencies and simplify linting usage as my PR changes.
related:
@rxts/eslint-plugin-mdx
has been renamed toeslint-plugin-mdx
, thanks to @azz