Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: move all devDependencies to root package.json, prettier all files #857

Merged
merged 13 commits into from Dec 1, 2019

Conversation

@JounQin
Copy link
Member

JounQin commented Dec 1, 2019

The devDependencies are all redundant added and installed, this PR makes them simple.

JounQin added 2 commits Dec 1, 2019
…es except .md/.mdx temporarily
@JounQin JounQin requested review from wooorm, johno and jxnblk Dec 1, 2019
@now

This comment has been minimized.

Copy link

now bot commented Dec 1, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/mdx/mdx/5u3emh8fh
🌍 Preview: https://mdx-git-perf-devdepends.mdx.now.sh

JounQin added 2 commits Dec 1, 2019
@now now bot had a problem deploying to staging Dec 1, 2019 Failure
@JounQin

This comment has been minimized.

Copy link
Member Author

JounQin commented Dec 1, 2019

Additionally, I want to run prettier for all possible files including .md and .mdx.

#844

What do you think?

@mdx-js/core

JounQin added 2 commits Dec 1, 2019
@now now bot had a problem deploying to staging Dec 1, 2019 Failure
@now now bot had a problem deploying to staging Dec 1, 2019 Failure
@now now bot had a problem deploying to staging Dec 1, 2019 Failure
JounQin added 2 commits Dec 1, 2019
@now now bot had a problem deploying to staging Dec 1, 2019 Failure
@now now bot requested a deployment to staging Dec 1, 2019 Pending
@JounQin JounQin self-assigned this Dec 1, 2019
@JounQin JounQin added this to In progress in MDX via automation Dec 1, 2019
@now now bot requested a deployment to staging Dec 1, 2019 Pending
@JounQin

This comment has been minimized.

Copy link
Member Author

JounQin commented Dec 1, 2019

Hey guys, finally, all the tests passed! Please help to review this PR which is very important internal improvement!

cc @mdx-js/core @mdx-js/maintainers @mdx-js/members

@timneutkens

This comment has been minimized.

Copy link
Member

timneutkens commented Dec 1, 2019

In general it'd be better to do the prettier change in a separate PR. But overall I think this is fine (didn't review line by line).

@wooorm

This comment has been minimized.

Copy link
Member

wooorm commented Dec 1, 2019

Same as Tim; looks good and would suggest, for the future, to split PRs to do one thing (especially because the prettier changes are so big, making it hard to review!)

@JounQin

This comment has been minimized.

Copy link
Member Author

JounQin commented Dec 1, 2019

@timneutkens @wooorm Thx for your great suggestions, I'll try to do better next time.

Would you like to approve this PR?

@JounQin

This comment has been minimized.

Copy link
Member Author

JounQin commented Dec 1, 2019

I'm going to merge this PR without your approves temporarily. Feel free to point out my faults and I'll fix them ASAP.

@JounQin JounQin merged commit cf74138 into master Dec 1, 2019
19 checks passed
19 checks passed
Build on ubuntu-latest with node.js 10
Details
Build on ubuntu-latest with node.js 10
Details
Build on ubuntu-latest with node.js 12
Details
Build on ubuntu-latest with node.js 12
Details
Build on windows-latest with node.js 10
Details
Build on windows-latest with node.js 10
Details
Build on windows-latest with node.js 12
Details
Build on windows-latest with node.js 12
Details
Build on macos-latest with node.js 10
Details
Build on macos-latest with node.js 10
Details
Build on macos-latest with node.js 12
Details
Build on macos-latest with node.js 12
Details
Build test and deploy
Details
Build test and deploy
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
MDX automation moved this from In progress to Done Dec 1, 2019
@JounQin JounQin deleted the perf/dev_depends branch Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
MDX
  
Done
3 participants
You can’t perform that action at this time.