Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: runtime should be bundled and considered as node pkg - fix #876 #877

Merged
merged 1 commit into from Dec 20, 2019

Conversation

@JounQin
Copy link
Member

JounQin commented Dec 20, 2019

@pkgr/rollup considers all dependencies as external automatically for node pkgs, but we didn't add engines field in package.json, so I accidentally removed @mdx-js/runtime to be bundled.

@now

This comment has been minimized.

Copy link

now bot commented Dec 20, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/mdx/mdx/5z17e9yi5
🌍 Preview: https://mdx-git-fix-runtime.mdx.now.sh

@JounQin JounQin force-pushed the fix/runtime branch from 88218b9 to 457aa52 Dec 20, 2019
@JounQin JounQin self-assigned this Dec 20, 2019
@now now bot temporarily deployed to staging Dec 20, 2019 Inactive
@JounQin JounQin force-pushed the fix/runtime branch from 87c6249 to a6c56b6 Dec 20, 2019
@JounQin JounQin merged commit 077e747 into master Dec 20, 2019
18 of 19 checks passed
18 of 19 checks passed
Build on ubuntu-latest with node.js 10
Details
Build on ubuntu-latest with node.js 10
Details
Build on ubuntu-latest with node.js 12
Details
Build on ubuntu-latest with node.js 12
Details
Build on windows-latest with node.js 10
Details
Build on windows-latest with node.js 10
Details
Build on windows-latest with node.js 12
Details
Build on windows-latest with node.js 12
Details
Build on macos-latest with node.js 10
Details
Build on macos-latest with node.js 10
Details
Build on macos-latest with node.js 12
Details
Build on macos-latest with node.js 12
Details
Build test and deploy
Details
Build test and deploy
Details
Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now Deployment has completed
Details
@JounQin JounQin deleted the fix/runtime branch Dec 20, 2019
@JounQin

This comment has been minimized.

Copy link
Member Author

JounQin commented Dec 20, 2019

@mdx-js/releasers Please help to release a new patch version for @mdx-js/runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.