Adding support to install nodejs to windows node from package #48

Closed
wants to merge 31 commits into
from

Conversation

Projects
None yet
4 participants

This is an effort to add support for installing nodejs to a windows chef node. I took the approach of integrating with your current recipes, as opposed to adding a new one. perhaps some day there could be support for installing to windows from binary and from source, as well.

I see some options besides the one I implemented in default.rb (including the install_from_package recipe, then returning):

  • we could require windows nodes to use a role attribute to change the install_method from default value of 'source', then default.rb recipe can remain unchanged. This is the most robust, allowing for future recipe changes to support install from source and binary for windows.
  • we could merely overwrite the install_method attribute in default.rb, then not return and let the recipe get included from the same point as for the linux platforms.

DevOpsDevine and others added some commits Jun 21, 2013

adding cookbook attribute comment block to windows.rb, and correctly …
…referencing the new attribute structure in the windows portion of the install_from__package recipe
Merge pull request #1 from daptiv/add-windows-support
adding windows support through install_from_package.rb
Fixed cookbook to work on Windows
Previously it didn't work on Windows despite claims it did. Moved Windows functionality to its own recipe and ensure none of the Linux pieces run on Windows. Ensures the minitests for Windows only run on Windows.
Applied latest version of upstream cookbook ot install_from_binary re…
…cipe

The recipe was not working correctly before the update

What are the changes to get this merged? Any issues in the PR?

sneal commented Mar 19, 2014

@DevOpsDevine We should close this PR. We have since forked and updated this cookbook here.

Agreed.

JenRed12 pushed a commit to Tealium/nodejs-cookbook that referenced this pull request Jun 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment